| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Erik Wienhold <ewie(at)ewie(dot)name>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump --no-comments confusion |
| Date: | 2024-11-04 20:00:03 |
| Message-ID: | ZyknwyfEUA86sXAi@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 4, 2024 at 07:49:45PM +0100, Daniel Gustafsson wrote:
> > On 4 Nov 2024, at 17:24, Erik Wienhold <ewie(at)ewie(dot)name> wrote:
> > But I also think that
> > "SQL" in front of the command name is unnecessary because the man page
> > uses the "FOOBAR command" form throughout
>
> Agreed.
>
> > --inserts
> > Dump data as INSERT commands [...]
> >
> > Also, it doesn't really matter whether COMMENT is standard SQL.
>
> AFAIK some flavor of COMMENT is present in MySQL, PostgreSQL and Oracle which
> already makes it more "standardized" than many parts of the SQL standard =)
Proposed patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
| Attachment | Content-Type | Size |
|---|---|---|
| comment.diff | text/x-diff | 462 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-11-04 20:03:44 | Re: pg_dump --no-comments confusion |
| Previous Message | Robert Haas | 2024-11-04 19:51:10 | Re: relfilenode statistics |