| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Erik Wienhold <ewie(at)ewie(dot)name>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump --no-comments confusion |
| Date: | 2024-11-05 21:55:16 |
| Message-ID: | CAEze2Wjo2zbEzv5=Q=cr6hkKW+Vchg5xj44cpB8oXGqwjK1rYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 4 Nov 2024 at 21:00, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Mon, Nov 4, 2024 at 07:49:45PM +0100, Daniel Gustafsson wrote:
> > > On 4 Nov 2024, at 17:24, Erik Wienhold <ewie(at)ewie(dot)name> wrote:
> > > But I also think that
> > > "SQL" in front of the command name is unnecessary because the man page
> > > uses the "FOOBAR command" form throughout
> >
> > Agreed.
> >
> > > --inserts
> > > Dump data as INSERT commands [...]
> > >
> > > Also, it doesn't really matter whether COMMENT is standard SQL.
> >
> > AFAIK some flavor of COMMENT is present in MySQL, PostgreSQL and Oracle which
> > already makes it more "standardized" than many parts of the SQL standard =)
Oh, I didn't know that, TIL.
> Proposed patch attached.
LGTM.
-Matthias
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2024-11-05 22:54:40 | Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE |
| Previous Message | Daniel Gustafsson | 2024-11-05 21:08:33 | Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c |