| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions |
| Date: | 2024-10-31 15:51:13 |
| Message-ID: | ZyOncTPYREmqJPLC@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 18, 2024 at 10:00:54AM +0800, jian he wrote:
> On Fri, Oct 18, 2024 at 2:05 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Yes, updated patch attached.
> >
> looks good.
>
> in the meantime, do you think it's necessary to slightly rephrase
> jsonb_path_match doc entry:
>
> currently doc entry:
> jsonb_path_match ( target jsonb, path jsonpath [, vars jsonb [, silent
> boolean ]] ) → boolean
> Returns the result of a JSON path predicate check for the specified JSON value.
>
>
> "the result of a JSON path predicate check for the specified JSON
> value." is a jsonb boolean.
> but jsonb_path_match returns sql boolean.
> maybe add something to describe case like: "if JSON path predicate
> check return jsonb null, jsonb_path_match will return SQL null".
Yes, I think that is a good point, updated patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
| Attachment | Content-Type | Size |
|---|---|---|
| json.diff | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-10-31 15:56:41 | Re: Count and log pages set all-frozen by vacuum |
| Previous Message | Peter Geoghegan | 2024-10-31 15:48:23 | Re: Count and log pages set all-frozen by vacuum |