Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions
Date: 2024-11-05 09:24:07
Message-ID: CACJufxF1xeqvEDEOK6na3_XjyzY4atAYFwh1DSxO1UxwF6+gUw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 31, 2024 at 11:51 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Fri, Oct 18, 2024 at 10:00:54AM +0800, jian he wrote:
> > On Fri, Oct 18, 2024 at 2:05 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > Yes, updated patch attached.
> > >
> > looks good.
> >
> > in the meantime, do you think it's necessary to slightly rephrase
> > jsonb_path_match doc entry:
> >
> > currently doc entry:
> > jsonb_path_match ( target jsonb, path jsonpath [, vars jsonb [, silent
> > boolean ]] ) → boolean
> > Returns the result of a JSON path predicate check for the specified JSON value.
> >
> >
> > "the result of a JSON path predicate check for the specified JSON
> > value." is a jsonb boolean.
> > but jsonb_path_match returns sql boolean.
> > maybe add something to describe case like: "if JSON path predicate
> > check return jsonb null, jsonb_path_match will return SQL null".
>
> Yes, I think that is a good point, updated patch attached.
>

played with
https://www.postgresql.org/docs/current/functions-json.html#FUNCTIONS-SQLJSON-FILTER-EX-TABLE

The patch looks good to me.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-11-05 09:33:13 Re: Time to add a Git .mailmap?
Previous Message Ronan Dunklau 2024-11-05 09:14:02 Re: Converting contrib SQL functions to new style