| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and [un]loggedness |
| Date: | 2024-09-20 00:37:54 |
| Message-ID: | ZuzD4govllMq5xyM@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 19, 2024 at 10:03:09AM +0200, Alvaro Herrera wrote:
> It looks to me like these cases could be modified to accept only
> ATT_PARTITIONED_TABLE, not ATT_TABLE anymore. The ATT_TABLE cases are
> useless anyway, because they're rejected by transformPartitionCmd.
Makes sense to me, thanks for the suggestion.
What do you think about adding a test with DETACH FINALIZE when
attempting it on a normal table, its path being under a different
subcommand than DETACH [CONCURRENTLY]?
There are no tests for normal tables with DETACH CONCURRENTLY, but as
it is the same as DETACH under the AT_DetachPartition subcommand, that
does not seem worth the extra cycles.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Harris | 2024-09-20 01:20:24 | Re: ANALYZE ONLY |
| Previous Message | Michael Paquier | 2024-09-19 23:59:51 | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind |