Re: Partitioned tables and [un]loggedness

On 2024-Sep-10, Michael Paquier wrote:

> @@ -5060,17 +5061,17 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd,
> pass = AT_PASS_MISC;
> break;
> case AT_AttachPartition:
> - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_INDEX);
> + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE | ATT_PARTITIONED_INDEX);
> /* No command-specific prep needed */
> pass = AT_PASS_MISC;
> break;
> case AT_DetachPartition:
> - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE);
> + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE);
> /* No command-specific prep needed */
> pass = AT_PASS_MISC;
> break;
> case AT_DetachPartitionFinalize:
> - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE);
> + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE);
> /* No command-specific prep needed */
> pass = AT_PASS_MISC;
> break;

It looks to me like these cases could be modified to accept only
ATT_PARTITIONED_TABLE, not ATT_TABLE anymore. The ATT_TABLE cases are
useless anyway, because they're rejected by transformPartitionCmd.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/