| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and [un]loggedness |
| Date: | 2024-09-24 00:06:40 |
| Message-ID: | ZvICkEXQJoi4irQs@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 20, 2024 at 09:37:54AM +0900, Michael Paquier wrote:
> What do you think about adding a test with DETACH FINALIZE when
> attempting it on a normal table, its path being under a different
> subcommand than DETACH [CONCURRENTLY]?
>
> There are no tests for normal tables with DETACH CONCURRENTLY, but as
> it is the same as DETACH under the AT_DetachPartition subcommand, that
> does not seem worth the extra cycles.
Added an extra test for the CONCURRENTLY case at the end, and applied
the simplification.
Hmm. Should we replace the error messages in transformPartitionCmd()
with some assertions at this stage? I don't see a high cost in
keeping these even now, and keeping errors is perhaps more useful for
some extension code that builds AT_AttachPartition or
AT_DetachPartition commands?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-09-24 00:30:59 | Re: Proposal to Enable/Disable Index using ALTER INDEX |
| Previous Message | Peter Smith | 2024-09-23 23:46:30 | Re: Pgoutput not capturing the generated columns |