Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Kane <andrew(at)ankane(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Date: 2024-09-13 21:41:23
Message-ID: ZuSxg3CKsIBhzZhn@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 13, 2024 at 04:58:20PM -0400, Tom Lane wrote:
> Andrew Kane <andrew(at)ankane(dot)org> writes:
>> With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and
>> `float_to_shortest_decimal_bufn` are not longer exported. This causes
>> `unresolved external symbol` linking errors for extensions that rely on
>> these functions (like pgvector). Can these functions be exported like
>> previous versions of Postgres?
>
> AFAICS it's in the exact same place it was in earlier versions.
> You might need to review your linking commands.

I do see a fair amount of special handling for f2s.c in the build files. I
wonder if something got broken for Windows in the switch from the MSVC
scripts to meson.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marcos Pegoraro 2024-09-13 21:41:30 Re: Detailed release notes
Previous Message Florents Tselai 2024-09-13 21:27:47 Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows