From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Minor refactor: Use more consistent names for the labels of PG_Locale_Strategy |
Date: | 2024-08-29 01:06:32 |
Message-ID: | Zs_JmA4hD8jsBZU1@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 28, 2024 at 04:58:16PM +0200, Andreas Karlsson wrote:
> When working on the regex code I noticed that the labels of
> PG_Locale_Strategy had become inconsistent with the addition of
> PG_REGEX_BUILTIN but while at it I also noticed that PG_REGEX_LOCALE_WIDE_L
> and PG_REGEX_LOCALE_1BYTE_L did not make it
> obvious that they were libc-related so I propose a new naming scheme:
>
> PG_STRATEGY_<type>[_<subtype>]
>
> I am open for other suggestions of course like keeping the PG_LOCALE_*
> prefix, but in any case I think we should make the enum labels consistent.
+1 for your suggestion, as you are suggesting. The original intention
when PG_Locale_Strategy got introduced was to have everything named as
PG_REGEX_LOCALE_*, but with the built-in part coming in play in this
code adding "STRATEGY" is cleaner than just "LOCALE".
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2024-08-29 01:06:45 | Re: Little cleanup of ShmemInit function names |
Previous Message | Peter Smith | 2024-08-29 00:31:18 | Re: Collect statistics about conflicts in logical replication |