| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Pluggable cumulative statistics |
| Date: | 2024-07-09 06:54:37 |
| Message-ID: | ZozerejiyKqEnYrZ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 08, 2024 at 02:07:58PM +0000, Bertrand Drouvot wrote:
> It looks pretty straightforward, just one comment:
>
> + ptr = ((char *) ctl) + kind_info->shared_ctl_off;
> + kind_info->init_shmem_cb((void *) ptr);
>
> I don't think we need to cast ptr to void when calling init_shmem_cb(). Looking
> at some examples in the code, it does not look like we cast the argument to void
> when a function has (void *) as parameter (also there is examples in 0003 where
> it's not done, see next comments for 0003).
Yep. Fine by me.
Please find attached a rebased patch set for now, to make the
CF bot happy.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-PgStat_KindInfo.init_shmem_cb.patch | text/x-diff | 10.4 KB |
| v5-0002-Add-a-new-F-type-of-entry-in-pgstats-file.patch | text/x-diff | 2.7 KB |
| v5-0003-Switch-PgStat_Kind-from-enum-to-uint32.patch | text/x-diff | 3.1 KB |
| v5-0004-Introduce-pluggable-APIs-for-Cumulative-Statistic.patch | text/x-diff | 20.2 KB |
| v5-0005-doc-Add-section-for-Custom-Cumulative-Statistics-.patch | text/x-diff | 3.3 KB |
| v5-0006-injection_points-Add-statistics-for-custom-points.patch | text/x-diff | 14.2 KB |
| v5-0007-injection_points-Add-example-for-fixed-numbered-s.patch | text/x-diff | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ikedarintarof | 2024-07-09 06:56:34 | Re: doc: modify the comment in function libpqrcv_check_conninfo() |
| Previous Message | Andres Freund | 2024-07-09 06:51:01 | Re: Meson far from ready on Windows |