| From: | ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: doc: modify the comment in function libpqrcv_check_conninfo() |
| Date: | 2024-07-09 06:56:34 |
| Message-ID: | 7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> - * Validate connection info string, and determine whether it might
> cause
> - * local filesystem access to be attempted.
> + * The function
> + * 1. validates connection info string and
> + * 2. checks a password is provided if must_use_password is true.
>
> IMO, "Validate connection info string" is sufficient. The mention of
> must_use_password is redundant since it's explained in the latter part
> of
> the comment.
That is reasonable for me. I've removed the second one.
The modified patch is attached.
Regards,
Rintaro Ikeda
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-07-09 07:15:39 | Re: SQL:2011 application time |
| Previous Message | Michael Paquier | 2024-07-09 06:54:37 | Re: Pluggable cumulative statistics |