Re: Meson far from ready on Windows

From: Andres Freund <andres(at)anarazel(dot)de>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Meson far from ready on Windows
Date: 2024-07-09 06:51:01
Message-ID: 20240709065101.xhc74r3mdg2lmn4w@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I've been hacking on addressing some of the complaints (after having been
off-work in a somewhat unplanned way for most of the last two weeks). With
some already opened and soon-to-be-proposed PRs to Dave's winbuild and the
attached changes I think the concerns can largely be addressed.

Here's the current set of changes:

0001: meson: Add missing argument to gssapi.h check
Largely independent, but included to avoid conflicts

0002: Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H
Largely independent, but included to avoid conflicts

0003: meson: Add support for detecting gss without pkg-config
0004: meson: Add support for detecting ossp-uuid without pkg-config
Do what it says on the tin. Neither includes dependency information via
pkg-config or cmake in their upstream repos.

0005: meson: Add dependency lookups via names used by cmake

This adds support for the alternative names used by cmake lookups. That
addresses

0006: meson: nls: Handle intl requiring iconv
This afaict is only required when dealing with a static libc, so it might be
considered independent

0007: windows-tab-complete-workaround
Just included so the build doesn't fail for me with all the dependencies
installed.

0008: krb-vs-openssl-workaround
Just included so the build doesn't fail for me with all the dependencies
installed. There's a separate thread to discuss the right fix.

0009: wip: meson: reduce linker noise for executables

This is mainly a minor quality of life thing for me when hacking on this. If
a static libintl is used, link.exe outputs a message for every binary, which
makes it harder to see warnings.

0010: meson: wip: tcl
This is just some preliminary hacking needs more work.

Note that cmake is automatically installed as part of visual studio these
days.

Greetings,

Andres Freund

Attachment Content-Type Size
v2-0001-meson-Add-missing-argument-to-gssapi.h-check.patch text/x-diff 1.8 KB
v2-0002-Don-t-define-HAVE_-GSSAPI_-GSSAPI_EXT_H.patch text/x-diff 4.3 KB
v2-0003-meson-Add-support-for-detecting-gss-without-pkg-c.patch text/x-diff 3.3 KB
v2-0004-meson-Add-support-for-detecting-ossp-uuid-without.patch text/x-diff 1.8 KB
v2-0005-meson-Add-dependency-lookups-via-names-used-by-cm.patch text/x-diff 3.7 KB
v2-0006-meson-nls-Handle-intl-requiring-iconv.patch text/x-diff 2.4 KB
v2-0007-windows-tab-complete-workaround.patch text/x-diff 1.3 KB
v2-0008-krb-vs-openssl-workaround.patch text/x-diff 1.3 KB
v2-0009-wip-meson-reduce-linker-noise-for-executables.patch text/x-diff 1.7 KB
v2-0010-meson-wip-tcl.patch text/x-diff 807 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-07-09 06:54:37 Re: Pluggable cumulative statistics
Previous Message Tatsuo Ishii 2024-07-09 06:44:09 Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN