Re: Meson far from ready on Windows

From: "Tristan Partin" <tristan(at)partin(dot)io>
To: "Andres Freund" <andres(at)anarazel(dot)de>, "Dave Page" <dpage(at)pgadmin(dot)org>
Cc: "Nazir Bilal Yavuz" <byavuz81(at)gmail(dot)com>, "PostgreSQL Developers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Meson far from ready on Windows
Date: 2024-07-16 20:53:45
Message-ID: D2R9FY2W0D7S.249249RYHGISR@partin.io
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres(at)anarazel(dot)de>
> Date: Mon, 8 Jul 2024 15:55:56 -0700
> Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H
>
> The check for gssapi_ext.h was added in f7431bca8b0. As we require
> gssapi_ext.h to be present, there's no point in defining symbols for the
> header presence.
>
> While at it, use cc.has_header() instead of cc.check_header(), that's a bit
> cheaper and it seems improbably that gssapi.h would compile while gssapi_ext.h
> would not.

improbable

Other than that, it looks pretty solid. Looks like we could help future
us out by teaching compiler.find_library() to take a list of names to
look at similar to how dependency() works now.

Reviewed-by: Tristan Partin <tristan(at)partin(dot)io>

--
Tristan Partin
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-07-16 20:56:11 Re: walsender.c fileheader comment
Previous Message Jeff Davis 2024-07-16 20:47:08 Re: [18] Policy on IMMUTABLE functions and Unicode updates