| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Mats Kindahl <mats(at)timescale(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery |
| Date: | 2024-03-06 22:45:01 |
| Message-ID: | Zejx7T8sKsbP0yJV@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 06, 2024 at 10:32:01AM +0100, Jelte Fennema-Nio wrote:
> This patch would definitely be useful for Citus. We indeed currently
> copy all of that code into our own explain hook. And it seems we
> actually have some bug. Because the es->memory branches were not
> copied (probably because this code didn't exist when we copied it).
>
> https://github.com/citusdata/citus/blob/d59c93bc504ad32621d66583de6b65f936b0ed13/src/backend/distributed/planner/multi_explain.c#L1248-L1289
That's nice. You would be able to shave quite a bit of code. If
there are no objections, I propose to apply the change of this thread
to have this standard explain wrapper at the beginning of next week.
If others have any comments, feel free.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2024-03-06 22:45:27 | Re: [PATCH] Exponential backoff for auth_delay |
| Previous Message | Isaac Morland | 2024-03-06 22:33:33 | Re: Reducing the log spam |