Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Mats Kindahl <mats(at)timescale(dot)com>
Cc: Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery
Date: 2024-03-06 09:32:01
Message-ID: CAGECzQRTTZviydquT7qgusy+=_n-o5+4c5rNYw4kkLy+mA5h4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This patch would definitely be useful for Citus. We indeed currently
copy all of that code into our own explain hook. And it seems we
actually have some bug. Because the es->memory branches were not
copied (probably because this code didn't exist when we copied it).

https://github.com/citusdata/citus/blob/d59c93bc504ad32621d66583de6b65f936b0ed13/src/backend/distributed/planner/multi_explain.c#L1248-L1289

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2024-03-06 09:32:31 Regarding the order of the header file includes
Previous Message Jelte Fennema-Nio 2024-03-06 09:19:41 Re: Injection points: some tools to wait and wake