Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date: 2025-04-05 08:24:41
Message-ID: Z_DoyQRKsq6XnS_F@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Mar 30, 2025 at 11:12:20AM -0700, Jeff Davis wrote:
> Why pg_strdup() the "NULL" at all in that case? Usually I see that done
> so that there doesn't need to be a conditional when freeing, but here
> there's a conditional anyway.
>
> Perhaps something like the attached?

I am back to a laptop, and just noticed that you have applied
f4e51eab4eb0 into the tree to take care of this issue, affecting only
HEAD. Why didn't you do a backpatch of this commit down to v16?
That's down to where 2a083ab807db has been applied.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-04-05 09:27:59 pgsql: pg_dump: Tiny header cleanup
Previous Message Tom Lane 2025-04-05 06:10:10 Re: pgsql: Prevent redeclaration of typedef TocEntry.