From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_dump: Tiny header cleanup |
Date: | 2025-04-05 09:27:59 |
Message-ID: | E1u0zol-002mPZ-10@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_dump: Tiny header cleanup
In commits 9c02e3a986da and 8ec0aaeae094, Nathan added a duplicate
TocEntry typedef forward declaration (plus assorted #ifdef hackery to
avoid C99 preprocessor issues) to deal with some very old untidyness
regarding DefnDumperPtr function prototype being located in pg_backup.h.
But there's no reason to have the DefnDumperPtr typedef (and the
accompanying DataDumperPtr typedef) in that file at all; they are better
placed in pg_backup_archiver.h, the internal header, because they are
only used internally. That also requires zero #ifdef hackery, so move
them there.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/202504042140.qo66ggw6wzsz@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4be6a74cfb1ef4c50740e4c2f97a3b478c16de73
Modified Files
--------------
src/bin/pg_dump/pg_backup.h | 10 ----------
src/bin/pg_dump/pg_backup_archiver.h | 7 ++++---
2 files changed, 4 insertions(+), 13 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-04-05 09:45:00 | pgsql: Set log_statement=none in t/002_pg_upgrade.pl |
Previous Message | Michael Paquier | 2025-04-05 08:24:41 | Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing |