Re: pgsql: Prevent redeclaration of typedef TocEntry.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Nathan Bossart <nathan(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
Date: 2025-04-05 06:10:10
Message-ID: 2408468.1743833410@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> ... AFAICS we could move both DefnDumperPtr and
> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
> _tocEntry (the only place where they are used), and we'd have less of a
> mess here. Then we don't need struct TocEntry in pg_backup.h anymore.

+1 for this simplification.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-04-05 08:24:41 Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Previous Message Nathan Bossart 2025-04-05 02:06:14 pgsql: pg_dump: Fix query for gathering attribute stats on older versio