Re: Show WAL write and fsync stats in pg_stat_io

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "bharath(dot)rupireddyforpostgres(at)gmail(dot)com" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Show WAL write and fsync stats in pg_stat_io
Date: 2025-03-18 23:33:37
Message-ID: Z9oC0eaIUAA2fFJ5@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 18, 2025 at 04:13:15PM +0300, Nazir Bilal Yavuz wrote:
> Thanks for the report! Yes, it is an oversight on my part.

No worries. It's most likely me while reviewing the whole as I've
reordered these blocks a bit while going through the patch.

This has little consequences for the end user, as the read, read_bytes
and read_time should show up as 0 instead of NULL in the pg_stat_io
view for the two WAL rows. Still it is confusing to show zeros, and
it makes queries of pg_stat_io a bit cheaper. Will fix in a bit.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-03-18 23:45:55 Re: maintenance_work_mem = 64kB doesn't work for vacuum
Previous Message David G. Johnston 2025-03-18 23:32:19 Re: Forbid to DROP temp tables of other sessions