Re: Show WAL write and fsync stats in pg_stat_io

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "bharath(dot)rupireddyforpostgres(at)gmail(dot)com" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Show WAL write and fsync stats in pg_stat_io
Date: 2025-03-19 12:10:00
Message-ID: CAEudQApjuqHgSyX0JGEu0pdhsWq+OQHjTZPoAhKihABmm2qcng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 18 de mar. de 2025 às 20:34, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:

> On Tue, Mar 18, 2025 at 04:13:15PM +0300, Nazir Bilal Yavuz wrote:
> > Thanks for the report! Yes, it is an oversight on my part.
>
> No worries. It's most likely me while reviewing the whole as I've
> reordered these blocks a bit while going through the patch.
>
> This has little consequences for the end user, as the read, read_bytes
> and read_time should show up as 0 instead of NULL in the pg_stat_io
> view for the two WAL rows. Still it is confusing to show zeros, and
> it makes queries of pg_stat_io a bit cheaper. Will fix in a bit.
>
Thank you Michael.

best regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-03-19 12:27:31 Re: Snapshot related assert failure on skink
Previous Message Christoph Berg 2025-03-19 12:02:54 Re: query_id: jumble names of temp tables for better pg_stat_statement UX