Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2025-01-24 06:22:48
Message-ID: Z5MxuDQBr_S8YNwW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 23, 2025 at 08:25:45PM +0000, Dagfinn Ilmari Mannsåker wrote:
> Here's a patch for that.

Thanks. I had a bit of time today and applied it.

- 'multiple -c options with different case');
+ 'multiple ---set options with different case');

This description had one character it did not need.

I was looking at the rest of the tree with the following command, and
there still more that could be switched (not surprising):
git grep "'\-[a-z]" -- *.pl

Perhaps not all of them are worth doing, but I'd surely welcome the
pg_upgrade part. If more work is done, let's move to a separate
thread; a lot of work has been done here already.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-01-24 06:28:08 RE: Proposal: Filter irrelevant change before reassemble transactions during logical decoding
Previous Message Corey Huinker 2025-01-24 05:20:59 Re: Extended Statistics set/restore/clear functions.