Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2025-01-24 16:03:31
Message-ID: 379085.1737734611@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Jan 23, 2025 at 08:25:45PM +0000, Dagfinn Ilmari Mannsåker wrote:
>> Here's a patch for that.

> Thanks. I had a bit of time today and applied it.

BF member drongo doesn't like the new test for amcheck.
Looks like it has to do with SSPI authentication producing
a different error than expected:

stderr:
# Failed test 'checking with a non-existent user stderr /(?^:role "no_such_user" does not exist)/'
# at C:/prog/bf/root/HEAD/pgsql/src/bin/pg_amcheck/t/002_nonesuch.pl line 86.
# 'pg_amcheck: error: connection to server at "127.0.0.1", port 19928 failed: FATAL: SSPI authentication failed for user "no_such_user"
# '
# doesn't match '(?^:role "no_such_user" does not exist)'
# Looks like you failed 1 test of 107.

You might be able to work around this with auth_extra,
a la 1e3f461e8 and other past fixes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2025-01-24 16:04:58 Re: Orphaned users in PG16 and above can only be managed by Superusers
Previous Message Nathan Bossart 2025-01-24 16:01:42 Re: Orphaned users in PG16 and above can only be managed by Superusers