Re: convert libpgport's pqsignal() to a void function

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: convert libpgport's pqsignal() to a void function
Date: 2025-01-15 03:57:57
Message-ID: Z4cyRX-hqfXREYKC@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote:
> LGTM, although I don't know enough about Windows to know if the
> "== SIG_ERR" test in that path is correct.

It's apparently not [0]. :(

My guess is that this has something to do with redefining SIG_ERR in
win32_port.h. We might be able to use push_macro/pop_macro to keep the old
value around, but at the moment I'm leaning towards just removing the
assertion in that path.

[0] https://cirrus-ci.com/task/6237809813487616

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-15 04:08:05 Re: convert libpgport's pqsignal() to a void function
Previous Message vignesh C 2025-01-15 03:49:16 Re: Introduce XID age and inactive timeout based replication slot invalidation