Re: convert libpgport's pqsignal() to a void function

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: convert libpgport's pqsignal() to a void function
Date: 2025-01-15 03:02:46
Message-ID: 1164438.1736910166@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> Thanks to commit 9a45a89, legacy-pqsignal.c now has its own dedicated
> extern for pqsignal(), which decouples it enough that we can follow through
> with changing libpqport's pqsignal() to a void function.

> Thoughts?

LGTM, although I don't know enough about Windows to know if the
"== SIG_ERR" test in that path is correct.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-01-15 03:49:16 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message Nathan Bossart 2025-01-15 02:45:12 convert libpgport's pqsignal() to a void function