| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: convert libpgport's pqsignal() to a void function |
| Date: | 2025-01-15 04:08:05 |
| Message-ID: | 1171432.1736914085@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote:
>> LGTM, although I don't know enough about Windows to know if the
>> "== SIG_ERR" test in that path is correct.
> It's apparently not [0]. :(
Bleah.
> My guess is that this has something to do with redefining SIG_ERR in
> win32_port.h. We might be able to use push_macro/pop_macro to keep the old
> value around, but at the moment I'm leaning towards just removing the
> assertion in that path.
I wonder why we redefine those values? But I tend to agree that just
removing the test is sufficient for now. Given the lack of failure
checks in the existing code, and the lack of trouble reports
suggesting any problem, it's hard to muster enthusiasm for spending
a lot of effort on this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-01-15 04:08:12 | Re: Conflict detection for update_deleted in logical replication |
| Previous Message | Nathan Bossart | 2025-01-15 03:57:57 | Re: convert libpgport's pqsignal() to a void function |