Re: convert libpgport's pqsignal() to a void function

On Tue, Jan 14, 2025 at 11:08:05PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> My guess is that this has something to do with redefining SIG_ERR in
>> win32_port.h. We might be able to use push_macro/pop_macro to keep the old
>> value around, but at the moment I'm leaning towards just removing the
>> assertion in that path.
>
> I wonder why we redefine those values?

I wondered the same. Those redefines have been there since commit 5049196,
but I haven't been able to find any real discussion in the archives about
it. Maybe I will bug Magnus about it sometime, in case he happens to
remember the reason.

> But I tend to agree that just
> removing the test is sufficient for now. Given the lack of failure
> checks in the existing code, and the lack of trouble reports
> suggesting any problem, it's hard to muster enthusiasm for spending
> a lot of effort on this.

Assuming cfbot likes this new version of the patch, I'll commit it shortly.
Thanks for reviewing.

--
nathan