Re: query_id: jumble names of temp tables for better pg_stat_statement UX

From: Christoph Berg <myon(at)debian(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date: 2025-03-24 15:41:35
Message-ID: Z-F9L8nGd72E8d2G@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Re: Michael Paquier
> So your idea to use the relation name in eref while skipping the
> column list looks kind of promising. Per se the attached. Thoughts?

Makes sense to me, thanks for digging into it.

> +++ b/src/backend/nodes/queryjumblefuncs.c
> @@ -33,6 +33,7 @@
> #include "postgres.h"
>
> #include "access/transam.h"
> +#include "catalog/namespace.h"

No longer needed.

> +++ b/contrib/pg_stat_statements/sql/select.sql
> +SET search_path = 'pgss_schema_1';
> +SELECT count(*) FROM tab_search_same;
> +SELECT a, b FROM tab_search_same;
> +SELECT count(*) FROM tab_search_diff_1;
> +SELECT count(*) FROM tab_search_diff_2;
> +SELECT a FROM tab_search_diff_2;
> +SET search_path = 'pgss_schema_1';

Should this be pgss_schema_2 ?

Christoph

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message shammat 2025-03-24 15:51:28 Re: Experience and feedback on pg_restore --data-only
Previous Message Adrian Klaver 2025-03-24 15:31:49 Re: Experience and feedback on pg_restore --data-only

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-03-24 15:43:47 Re: AIO v2.5
Previous Message David G. Johnston 2025-03-24 15:30:47 Re: vacuum_truncate configuration parameter and isset_offset