Re: query_id: jumble names of temp tables for better pg_stat_statement UX

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date: 2025-03-25 03:47:19
Message-ID: Z-InR3Qs3KqKXCcz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Mon, Mar 24, 2025 at 04:41:35PM +0100, Christoph Berg wrote:
> Re: Michael Paquier
>> +++ b/src/backend/nodes/queryjumblefuncs.c
>> @@ -33,6 +33,7 @@
>> #include "postgres.h"
>>
>> #include "access/transam.h"
>> +#include "catalog/namespace.h"
>
> No longer needed.

Indeed.

>> +++ b/contrib/pg_stat_statements/sql/select.sql
>> +SET search_path = 'pgss_schema_1';
>> +SELECT count(*) FROM tab_search_same;
>> +SELECT a, b FROM tab_search_same;
>> +SELECT count(*) FROM tab_search_diff_1;
>> +SELECT count(*) FROM tab_search_diff_2;
>> +SELECT a FROM tab_search_diff_2;
>> +SET search_path = 'pgss_schema_1';
>
> Should this be pgss_schema_2 ?

Oops. Nice copy-paste.
--
Michael

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Michael Paquier 2025-03-25 03:51:12 Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Previous Message Sami Imseih 2025-03-25 03:30:59 Re: query_id: jumble names of temp tables for better pg_stat_statement UX

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-03-25 03:51:12 Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Previous Message Bertrand Drouvot 2025-03-25 03:44:42 Re: Fix 035_standby_logical_decoding.pl race conditions