| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jeff Davis <jdavis(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Respect permissions within logical replication. |
| Date: | 2022-01-08 09:25:17 |
| Message-ID: | YdlYfS/l+PQA0ehs@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote:
> 2) crake fails perl-check
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26
>
> All the failures are the same, because of the shape of the subroutine
> definitions:
> Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
> Subroutine prototypes used at line 13, column 1. See page 194 of
> PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)
This issue is just caused by the way the subroutines are defined,
meaning that the attached cools down pgperlcritic. Any objections if
I apply that to cool down crake? Jeff, if you wish to do so, please
feel free of course.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| crake-perlcritic.patch | text/x-diff | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-01-08 16:30:57 | Re: pgsql: Respect permissions within logical replication. |
| Previous Message | Michael Paquier | 2022-01-08 07:46:02 | pgsql: Fix issues with describe queries of extended statistics in psql |