| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <jdavis(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Respect permissions within logical replication. |
| Date: | 2022-01-08 16:30:57 |
| Message-ID: | b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 1/8/22 04:25, Michael Paquier wrote:
> On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote:
>> 2) crake fails perl-check
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26
>>
>> All the failures are the same, because of the shape of the subroutine
>> definitions:
>> Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
>> Subroutine prototypes used at line 13, column 1. See page 194 of
>> PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)
> This issue is just caused by the way the subroutines are defined,
> meaning that the attached cools down pgperlcritic. Any objections if
> I apply that to cool down crake? Jeff, if you wish to do so, please
> feel free of course.
Please do this. Subroutine prototypes should only be used in very
restricted circumstances in Perl. I can't recall when I've ever needed them.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2022-01-08 17:31:52 | pgsql: Fix pgperlcritic complaint, per buildfarm. |
| Previous Message | Michael Paquier | 2022-01-08 09:25:17 | Re: pgsql: Respect permissions within logical replication. |