Re: pgsql: Respect permissions within logical replication.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Respect permissions within logical replication.
Date: 2022-01-08 05:22:23
Message-ID: Ydkfj5IsZg7mQR0g@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Jeff,

On Sat, Jan 08, 2022 at 02:40:56AM +0000, Jeff Davis wrote:
> Respect permissions within logical replication.

The buildfarm is not completely happy after this commit:
1) massasauga is failing the new test:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=massasauga&dt=2022-01-08%2002%3A45%3A21
# Failed test 'superuser admin replicates insert into unpartitioned'
# at t/027_nosuperuser.pl line 46.
# got: '2|1|3'
# expected: '3|1|5'
# Looks like you failed 1 test of 100.

2) crake fails perl-check
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26

All the failures are the same, because of the shape of the subroutine
definitions:
Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
Subroutine prototypes used at line 13, column 1. See page 194 of
PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)

Thanks,
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2022-01-08 06:26:28 Re: pgsql: Respect permissions within logical replication.
Previous Message Jeff Davis 2022-01-08 02:40:56 pgsql: Respect permissions within logical replication.