Re: pgsql: Respect permissions within logical replication.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Respect permissions within logical replication.
Date: 2022-01-08 06:26:28
Message-ID: CAA4eK1+ywbYNSVcQgbTtjE7sX8xZi4jpNztb9Qw_yLC-W3O7sA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Jan 8, 2022 at 10:52 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi Jeff,
>
> On Sat, Jan 08, 2022 at 02:40:56AM +0000, Jeff Davis wrote:
> > Respect permissions within logical replication.
>
> The buildfarm is not completely happy after this commit:
> 1) massasauga is failing the new test:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=massasauga&dt=2022-01-08%2002%3A45%3A21
> # Failed test 'superuser admin replicates insert into unpartitioned'
> # at t/027_nosuperuser.pl line 46.
> # got: '2|1|3'
> # expected: '3|1|5'
> # Looks like you failed 1 test of 100.
>

One possible reason for this failure could be that the test doesn't
wait for the initial sync to complete after CREATE SUBSCRIPTION which
can allow more than expected operations to be replicated. Also, the
reason it passes in other machines is that in those runs initial sync
could get finished before we start to publish other operations.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-01-08 07:46:02 pgsql: Fix issues with describe queries of extended statistics in psql
Previous Message Michael Paquier 2022-01-08 05:22:23 Re: pgsql: Respect permissions within logical replication.