Re: pg_upgrade test failure

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade test failure
Date: 2022-10-18 04:06:15
Message-ID: Y04mN0ZLNzJywrad@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Oct 18, 2022 at 09:47:37AM +1300, Thomas Munro wrote:
> * Server 2019, as used on CI, still uses the traditional NT semantics
> (unlink is asynchronous, when all handles closes)
> * the fix I proposed has the right effect (I will follow up with tests
> to demonstrate)

Wow, nice investigation. And cirrus does not offer a newer option
either.. Do you think that Windows server 2022 (successor of 2019) is
able to use POSIX semantics for unlink()? It looks that we are a few
years away from being able to do that assuming that cirrus offers a
newer version than server 2019, but I guess that the code could
mention this possibility in a comment, at least..
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Justin Pryzby 2022-10-18 04:31:44 Re: pg_upgrade test failure
Previous Message Michael Paquier 2022-10-18 01:45:07 pgsql: Remove compatibility declarations for InitMaterializedSRF()

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-10-18 04:07:24 Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)
Previous Message houzj.fnst@fujitsu.com 2022-10-18 04:00:20 RE: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION