From: | <Hajime(dot)Matsunaga(at)nttdata(dot)com> |
---|---|
To: | <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, <byavuz81(at)gmail(dot)com>, <melanieplageman(at)gmail(dot)com> |
Cc: | <pgsql-hackers(at)lists(dot)postgresql(dot)org>, <Masao(dot)Fujii(at)nttdata(dot)com> |
Subject: | RE: Doc: fix track_io_timing description to mention pg_stat_io |
Date: | 2024-07-08 03:01:50 |
Message-ID: | TYWPR01MB1074289CA6F9E0228247EF31CA4DA2@TYWPR01MB10742.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Sent: Wednesday, July 3, 2024 7:44 PM
>
> On 2024/07/03 17:51, Hajime(dot)Matsunaga(at)nttdata(dot)com wrote:
> > Thanks for the suggestions the other day.
> > I have created a patch that incorporates your suggestions.
>
> - <structname>pg_stat_database</structname></link>, in the output of
> + <structname>pg_stat_database</structname></link> and
> + <link linkend="monitoring-pg-stat-io-view">
> + <structname>pg_stat_io</structname></link>, in the output of
>
> I'm not a native English speaker, but it seems more natural to use a comma instead of "and" before "pg_stat_io."
>
> - of block read and write times.
> + of block read, block write, extend, and fsync times.
>
> "block" before "fsync" doesn't seem necessary.
I'm also not a native English speaker, so I appreciate your feedback.
I have created a patch that incorporates your feedback.
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Doc-fix-track_io_timing-description-to-mention-pg.patch | application/octet-stream | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-07-08 03:16:19 | Re: walsender.c comment with no context is hard to understand |
Previous Message | Thomas Munro | 2024-07-08 02:56:38 | Re: Interrupts vs signals |