From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Hajime(dot)Matsunaga(at)nttdata(dot)com, byavuz81(at)gmail(dot)com, melanieplageman(at)gmail(dot)com |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Masao(dot)Fujii(at)nttdata(dot)com |
Subject: | Re: Doc: fix track_io_timing description to mention pg_stat_io |
Date: | 2024-07-10 07:02:32 |
Message-ID: | 8c2a0585-fb92-4eb2-b66f-8e69ba2cb2c8@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2024/07/08 12:01, Hajime(dot)Matsunaga(at)nttdata(dot)com wrote:
>
>
> From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
> Sent: Wednesday, July 3, 2024 7:44 PM
>>
>> On 2024/07/03 17:51, Hajime(dot)Matsunaga(at)nttdata(dot)com wrote:
>>> Thanks for the suggestions the other day.
>>> I have created a patch that incorporates your suggestions.
>>
>> - <structname>pg_stat_database</structname></link>, in the output of
>> + <structname>pg_stat_database</structname></link> and
>> + <link linkend="monitoring-pg-stat-io-view">
>> + <structname>pg_stat_io</structname></link>, in the output of
>>
>> I'm not a native English speaker, but it seems more natural to use a comma instead of "and" before "pg_stat_io."
>>
>> - of block read and write times.
>> + of block read, block write, extend, and fsync times.
>>
>> "block" before "fsync" doesn't seem necessary.
>
> I'm also not a native English speaker, so I appreciate your feedback.
> I have created a patch that incorporates your feedback.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2024-07-10 07:14:21 | Re: MERGE/SPLIT partition commands should create new partitions in the parent's tablespace? |
Previous Message | Amit Kapila | 2024-07-10 06:58:41 | Re: long-standing data loss bug in initial sync of logical replication |