RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

From: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
To: Önder Kalacı <onderkalaci(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date: 2023-03-22 08:08:22
Message-ID: TYAPR01MB6315B365D3A84AA65DDF6996FD869@TYAPR01MB6315.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 22, 2023 2:53 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
>
> We don't really need to, if you check the first patch, we don't have DROP for generated case. I mostly
> wanted to make the test a little more interesting, but it also seems to be a little confusing.
>
> Now attaching v2 where we do not drop the columns. I don't have strong preference on
> which patch to proceed with, mostly wanted to attach this version to progress faster (in case
> you/Amit considers this one better).
>

Thanks for updating the patches.
The v2 patch LGTM.

Regards,
Shi Yu

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Zubkov 2023-03-22 08:17:00 Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements
Previous Message houzj.fnst@fujitsu.com 2023-03-22 07:52:32 RE: Initial Schema Sync for Logical Replication