| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |
| Date: | 2023-03-22 06:53:04 |
| Message-ID: | CACawEhVTFnDh70eJGh_ww1nYu1SvMSqyECxLQVxjcWzf4ybDEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shi Yu,
>
> Is there any reasons why we drop column here? Dropped column case has been
> tested on table dropped_cols. The generated column problem can be detected
> without dropping columns on my machine.
>
We don't really need to, if you check the first patch, we don't have DROP
for generated case. I mostly
wanted to make the test a little more interesting, but it also seems to be
a little confusing.
Now attaching v2 where we do not drop the columns. I don't have strong
preference on
which patch to proceed with, mostly wanted to attach this version to
progress faster (in case
you/Amit considers this one better).
Thanks,
Onder
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-REL_12-Ignore-generated-columns-during-apply-of-update-d.patch | application/octet-stream | 3.6 KB |
| v2-0001-HEAD-Ignore-generated-columns-during-apply-of-update-d.patch | application/octet-stream | 3.4 KB |
| v2-0001-REL_15-Ignore-generated-columns-during-apply-of-update-d.patch | application/octet-stream | 3.5 KB |
| v2-0001-REL_14-REL_13-Ignore-generated-columns-during-apply-of-update-d.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-03-22 07:34:00 | meson: Fix support for empty darwin sysroot |
| Previous Message | Michael Paquier | 2023-03-22 06:48:46 | Re: User functions for building SCRAM secrets |