| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |
| Date: | 2023-03-22 02:13:13 |
| Message-ID: | OSZPR01MB63103CE46A7A7C177509C68FFD869@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, March 21, 2023 8:03 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
>
> Attached patches again.
>
Thanks for updating the patch.
@@ -408,15 +412,18 @@ $node_subscriber->wait_for_subscription_sync;
$node_publisher->safe_psql(
'postgres', qq(
ALTER TABLE dropped_cols DROP COLUMN b_drop;
+ ALTER TABLE generated_cols DROP COLUMN c_drop;
));
$node_subscriber->safe_psql(
'postgres', qq(
ALTER TABLE dropped_cols DROP COLUMN b_drop;
+ ALTER TABLE generated_cols DROP COLUMN c_drop;
));
Is there any reasons why we drop column here? Dropped column case has been
tested on table dropped_cols. The generated column problem can be detected
without dropping columns on my machine.
Regards,
Shi Yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2023-03-22 02:19:41 | Re: Improve logging when using Huge Pages |
| Previous Message | Peter Geoghegan | 2023-03-22 01:31:09 | Re: Show various offset arrays for heap WAL records |