| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Önder Kalacı <onderkalaci(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |
| Date: | 2023-03-23 13:45:48 |
| Message-ID: | CAA4eK1JsJ9hAih3NjRVVY7q3Fo-YPcGBgUW=jr9AjFk_-GegMA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 22, 2023 at 1:39 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Wed, Mar 22, 2023 2:53 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
> >
> > We don't really need to, if you check the first patch, we don't have DROP for generated case. I mostly
> > wanted to make the test a little more interesting, but it also seems to be a little confusing.
> >
> > Now attaching v2 where we do not drop the columns. I don't have strong preference on
> > which patch to proceed with, mostly wanted to attach this version to progress faster (in case
> > you/Amit considers this one better).
> >
>
> Thanks for updating the patches.
> The v2 patch LGTM.
>
Pushed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imseih (AWS), Sami | 2023-03-23 13:54:05 | Re: [BUG] pg_stat_statements and extended query protocol |
| Previous Message | Robert Haas | 2023-03-23 13:42:16 | Re: HOT chain validation in verify_heapam() |