| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |
| Date: | 2024-12-10 02:12:27 |
| Message-ID: | TYAPR01MB56923CE2FEE95CE4A89CED61F53D2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shubham,
Thanks for the proposal!
> I am writing to propose the addition of the two_phase option in
> pg_createsubscriber. As discussed in [1], supporting this feature
> during the development of pg_createsubscriber was planned for this
> version.
Yes, that was the pending item.
> The attached patch has the changes for the same.
There are API related comments.
01.
I think the two-phase should be off by default. Because default value for CREATE
SUBSCRIPTION command is off, and your patch breaks pre-existing style.
02.
API style should be changed: no need to require the argument. I think it is enough
to provide "enable-twophase" and "T" option which specify the two_phase to true.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-12-10 02:18:48 | Re: Fix some comments for GUC hooks of timezone_abbreviations |
| Previous Message | Thomas Munro | 2024-12-10 02:02:07 | Re: Cannot find a working 64-bit integer type on Illumos |