Re: CLUSTER patch and regression test

From: Alvaro Herrera <alvherre(at)atentus(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: CLUSTER patch and regression test
Date: 2002-08-08 06:18:50
Message-ID: Pine.LNX.4.44.0208080214140.11866-400000@cm-lcon1-46-187.cm.vtr.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane dijo:

> Looks like Alvaro got sideswiped by the system catalog indexing changes
> I made over the weekend. It's a simple change, just reduce the whole
> mess to a "CatalogUpdateIndexes()" call.

I update two tuples, so I manually CatalogOpenIndexes() and
CatalogIndexInsert() two times, as per comments in
CatalogUpdateIndexes().

I also removed a couple of useless CommandCounterIncrement(), some
useless definitions in src/include/commands/cluster.h and useless
includes in src/backend/commands/cluster.c. This version passes the
regression test I had made for previous versions.

If it applies cleanly, please apply :-)

--
Alvaro Herrera (<alvherre[a]atentus.com>)
La web junta la gente porque no importa que clase de mutante sexual seas,
tienes millones de posibles parejas. Pon "buscar gente que tengan sexo con
ciervos incendiánse", y el computador dirá "especifique el tipo de ciervo"
(Jason Alexander)

Attachment Content-Type Size
cluster.patch text/plain 16.4 KB
cluster.out text/plain 6.5 KB
cluster.sql text/plain 2.9 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Pierre-Yves LANDURE 2002-08-08 06:37:11 Re: Polygon contrib
Previous Message Tom Lane 2002-08-08 05:21:43 Re: stand-alone composite types patch (was [HACKERS] Proposal: stand-alone composite types)