Re: CLUSTER patch and regression test

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)atentus(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: CLUSTER patch and regression test
Date: 2002-08-10 21:03:41
Message-ID: 200208102103.g7AL3f825271@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


I have backed out the older patch and replaced it with this new one.

Thanks.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Tom Lane dijo:
>
> > Looks like Alvaro got sideswiped by the system catalog indexing changes
> > I made over the weekend. It's a simple change, just reduce the whole
> > mess to a "CatalogUpdateIndexes()" call.
>
> I update two tuples, so I manually CatalogOpenIndexes() and
> CatalogIndexInsert() two times, as per comments in
> CatalogUpdateIndexes().
>
> I also removed a couple of useless CommandCounterIncrement(), some
> useless definitions in src/include/commands/cluster.h and useless
> includes in src/backend/commands/cluster.c. This version passes the
> regression test I had made for previous versions.
>
> If it applies cleanly, please apply :-)
>
> --
> Alvaro Herrera (<alvherre[a]atentus.com>)
> La web junta la gente porque no importa que clase de mutante sexual seas,
> tienes millones de posibles parejas. Pon "buscar gente que tengan sexo con
> ciervos incendi?nse", y el computador dir? "especifique el tipo de ciervo"
> (Jason Alexander)

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-10 21:04:08 Re: CLUSTER patch and regression test
Previous Message Bruce Momjian 2002-08-10 20:50:59 Re: clean up assertion code