Re: CLUSTER patch and regression test

Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
>> I sent the CLUSTER patch a few days ago and I think it was missed. I
>> append it again, this time including the regression test files.

> Applying the patch to current CVS and compiling produces:

> gcc -g3 -O0 -DPS_USE_NONE -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../src/include -c -o cluster.o cluster.c -MMD
> cluster.c: In function `swap_relfilenodes':
> cluster.c:383: `Num_pg_class_indices' undeclared (first use in this function)
> cluster.c:383: (Each undeclared identifier is reported only once
> cluster.c:383: for each function it appears in.)
> cluster.c:432: warning: implicit declaration of function `CatalogOpenIndices'

Looks like Alvaro got sideswiped by the system catalog indexing changes
I made over the weekend. It's a simple change, just reduce the whole
mess to a "CatalogUpdateIndexes()" call.

regards, tom lane