Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen

Thanks for your replies and corrections, and apologies for the confusing version I mentioned.

For this commit, PostgreSQL was successfully built with msvc on both x86 and amd64.

Glad my report was helpful.

Mo

________________________________
From: David Rowley <dgrowleyml(at)gmail(dot)com>
Sent: Thursday, June 8, 2023 6:18
To: moyoumiu(at)outlook(dot)com <moyoumiu(at)outlook(dot)com>; pgsql-bugs(at)lists(dot)postgresql(dot)org <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen

On Thu, 8 Jun 2023 at 01:00, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I've not tested it, but I imagine the attached patch should fix it.

I've just pushed that patch to master only.

I noticed your report mentioned that this was for version 15.3. I
assumed this was a mistake as I didn't see any usage of the bit
scanning functions in v15. Commit 677319746 [1] introduced these,
which is new to v16.

Many thanks for reporting this!

David

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=677319746