| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Date: | 2025-03-19 06:59:07 |
| Message-ID: | OSCPR01MB14966D341D7E689DA6B78CAC4F5D92@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shubham,
One comment for the API. Currently the patch introduces new option '--remove',
and the short term is '-r'. My suggestion is to use '-R' instead.
Background
==========
IIUC, we've planned to put outut-logs in some files on the directory [1].
This follows what pg_ugprade does.
In pg_uprade, -r means "retain SQL and log files even after successful completion" [2].
Normally logs would be removed after the sucessful upgrade, but they would not with
the option.
If we use -r for removing objects in pg_createsubscriber, it would be conflicted
with the short term of --retain. This is confusing for users.
[1]: https://www.postgresql.org/message-id/60b45b8a-3047-4a21-ba2a-ddb15daa638f%40eisentraut.org
[2]: https://www.postgresql.org/docs/devel/pgupgrade.html
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gabriele Bartolini | 2025-03-19 07:03:08 | Re: RFC: Additional Directory for Extensions |
| Previous Message | Shubham Khanna | 2025-03-19 06:54:52 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |