Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Wed, Mar 19, 2025 at 12:29 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shubham,
>
> One comment for the API. Currently the patch introduces new option '--remove',
> and the short term is '-r'. My suggestion is to use '-R' instead.
>
> Background
> ==========
> IIUC, we've planned to put outut-logs in some files on the directory [1].
> This follows what pg_ugprade does.
>
> In pg_uprade, -r means "retain SQL and log files even after successful completion" [2].
> Normally logs would be removed after the sucessful upgrade, but they would not with
> the option.
>
> If we use -r for removing objects in pg_createsubscriber, it would be conflicted
> with the short term of --retain. This is confusing for users.
>
> [1]: https://www.postgresql.org/message-id/60b45b8a-3047-4a21-ba2a-ddb15daa638f%40eisentraut.org
> [2]: https://www.postgresql.org/docs/devel/pgupgrade.html
>

Changed -r to -R based on the shared analysis to avoid conflict with
the --retain option used in pg_upgrade and to maintain consistency
across tools.

The attached patch contains the suggested change.

Thanks and regards,
Shubham Khanna.