| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Date: | 2025-03-19 08:44:09 |
| Message-ID: | CAA4eK1+mfvp=_k+xqB8BwzNiGDNoTN_j9p=J3PWzFkkMSJCnZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 19, 2025 at 12:29 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> One comment for the API. Currently the patch introduces new option '--remove',
> and the short term is '-r'. My suggestion is to use '-R' instead.
>
> Background
> ==========
> IIUC, we've planned to put outut-logs in some files on the directory [1].
> This follows what pg_ugprade does.
>
> In pg_uprade, -r means "retain SQL and log files even after successful completion" [2].
> Normally logs would be removed after the sucessful upgrade, but they would not with
> the option.
>
> If we use -r for removing objects in pg_createsubscriber, it would be conflicted
> with the short term of --retain. This is confusing for users.
>
We have discussed in the past and in this thread as well to have a
functionality like pg_upgrade to have LOG and or SQL files in which
case we may need to have an option for --retain (-r) similar to
pg_upgrade. So, using -R for this option sounds reasonable to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christophe Pettus | 2025-03-19 08:53:37 | Vacuuming the free space map considered harmful? |
| Previous Message | Shubham Khanna | 2025-03-19 08:32:29 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |