make update-po problem with USE_PGXS

From: "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: make update-po problem with USE_PGXS
Date: 2021-11-01 03:56:41
Message-ID: OS3PR01MB7159613E0C14C023312FF104F28A9@OS3PR01MB7159.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I'm developing an extension, after modifying some source file(add some message
like gettext('xxxxx')) and execute
> $ make USE_PGXS=1 update-po
> make: Nothing to be done for 'update-po'.

I feel strange because I think *.po.new files should be created.

After some research, I find in $pginstall/lib/postgresql/pgxs/src/nls-global.mk
> ifneq (,$(filter update-po %.po.new,$(MAKECMDGOALS)))
> ALL_LANGUAGES := $(shell find $(top_srcdir) -name '*.po' -print | sed 's,^.*/\([^/]*\).po$$,\1,' | LC_ALL=C sort -u)
> all_compendia := $(shell find $(top_srcdir) -name '*.po' -print | LC_ALL=C sort)
> else

When USE_PGXS is on, the value of $(top_srcdir) is
> $pginstall/lib/postgresql/pgxs/src/makefiles/../..
Therefore, command find will nerver find any po file.

I think this is a problem and plan to modify this,
when USE_PGXS is on, we can use:
find . -name '*.po' -print

Or there are some advice/comments?

Regards
Shenhao Wang

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-11-01 04:26:46 Re: pg_receivewal starting position
Previous Message Michael Paquier 2021-11-01 02:55:40 Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY[