Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY[

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY[
Date: 2021-11-01 02:55:40
Message-ID: YX9XLOYc2kjejZ1g@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 30, 2021 at 09:26:35PM +0900, Michael Paquier wrote:
> Yeah, you are right that it would be better here to use
> get_attoptions() to grab a copy of each attribute's option directly
> from the catalogs. We also do that for predicates and expressions.

While looking again at this one this morning, I have extended the
tests with more columns and some default values, then applied the
patch by using get_attoptions() to grab each attribute's options as of
add5cf2. Predicates and expressions are grabbed through the syscache,
so that's just more consistent.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message wangsh.fnst@fujitsu.com 2021-11-01 03:56:41 make update-po problem with USE_PGXS
Previous Message Kyotaro Horiguchi 2021-11-01 02:40:19 Re: inefficient loop in StandbyReleaseLockList()