RE: fix a comment

From: "wangyukun(at)fujitsu(dot)com" <wangyukun(at)fujitsu(dot)com>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: fix a comment
Date: 2021-04-23 07:03:40
Message-ID: OS0PR01MB6003E518D8B42A156DB57F53B4459@OS0PR01MB6003.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Amul

Thank you for reviewing.

> How about simply removing these numbering?

Agree. Please see the v2 patch which delete the number in comment.

Best wishes
Yukun Wang

-----Original Message-----
From: Amul Sul <sulamul(at)gmail(dot)com>
Sent: Friday, April 23, 2021 3:51 PM
To: Wang, Yukun/王 俞坤 <wangyukun(at)fujitsu(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: fix a comment

On Fri, Apr 23, 2021 at 12:12 PM wangyukun(at)fujitsu(dot)com <wangyukun(at)fujitsu(dot)com> wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> > * Third, search through the result relations that were created
> > during
> > * tuple routing, if any.
> > */
>
> But the 'Second' was deleted since commit 1375422c78.
>
> Update the 'Third' to 'Second', please see the attachment.
>
> Thoughts?
>

Well yes, looks good to me.

How about simply removing these numbering?

Regards,
Amul

Attachment Content-Type Size
fix-a-comment.diff application/octet-stream 805 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-04-23 07:10:37 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Previous Message Joel Jacobson 2021-04-23 06:54:45 Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids